refactor(request): abstract https server into a tls server for protocol checks#311
refactor(request): abstract https server into a tls server for protocol checks#311J4Numbers wants to merge 1 commit intochaijs:mainfrom
Conversation
…ol checks The TLS.Server instance is common for both the https library and the http2 library, according to the NodeJS documentation. Since it is a common ancestor, we should check for this instance instead of the specific https flavour Signed-off-by: Jayne Doe <jayne.doe@engineering.digital.dwp.gov.uk>
|
Looks to resolve #245 through allowing the |
|
I've been out of the loop a while on node server stuff. Are there ramifications to this? Compatibility issues? What version of Node supports this? How will it effect our existing userbase? Should this be semver major? |
|
I was testing this on Node Functionaly, it's a non-breaking support change that could be argued into a patch to ensure that all From my understanding (and a bit of code changing on a local version of the library against an app), the change is transparent. |
The
TLS.Serverinstance is common for both thehttpslibrary and thehttp2library,according to the NodeJS documentation. Since it is a common ancestor, we should check for
this instance instead of the specific
httpsflavour.On a similar note, the
net.Serverinstance is common for bothhttpandhttp2too,though no changes are required to ensure they're cast to the same.
See the following links: