fix range issue + test pdo comm records + import union + add getitem#637
Open
luciademoja-lab wants to merge 1 commit intocanopen-python:masterfrom
Open
fix range issue + test pdo comm records + import union + add getitem#637luciademoja-lab wants to merge 1 commit intocanopen-python:masterfrom
luciademoja-lab wants to merge 1 commit intocanopen-python:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes PDO lookup and generic PDO mapping behavior in canopen so access via both PDO communication parameter records and mapping records works correctly.
Changes
Updated base.py
PdoMaps.getitem now resolves keys in both communication record (0x1400 / 0x1800) and mapping record (0x1600 / 0x1A00) ranges.
Updated init.py
PDO now normalizes alternate PDO index ranges and avoids duplicate counting while still supporting legacy lookup patterns.
Added missing Union import for type annotations.
Testing
Verified with python -m pytest test/test_pdo.py
Result: 7 passed, 1 skipped