Fix CI failures by updating OSError handling in test finalizers

[Harishmcw]

This PR fixes the CI failures on Windows builds.

The Problem

• The test suite was passing on windows-2022 but failing on windows-latest because GitHub updated the latter to Windows Server 2025. On this newer image, closing an invalid file descriptor now fails silently instead of raising an OSError. Since the test strictly expected a crash via pytest.raises(OSError), the lack of an exception caused a test failure.

The Soultion

• Updated the finalizer in tests/test_soundfile.py to use a try/except block. This ensures the file is closed if still open, but allows the test to pass if the OS handles the closure silently or if the library has already disposed of the resource.

[bastibe]

Can you point me to documentation of this behavior? This seems awfully strange.

I'm also a bit saddened that we're no longer checking for the OSError. Perhaps we should explicitly disable the check only on Windows?

[Harishmcw]

Thanks for the question, I investigated this further.

I verified that SoundFile correctly closes the file descriptor. After f.close(), the FD is invalid and operations like os.lseek() fail with EBADF, which confirms the expected behavior.

However, on the newer Windows CI environment (windows-latest), calling os.close(fd) on this already-closed descriptor does not raise OSError, which is what causes the test failure.

Minimal check I used:

import os
import numpy as np
import soundfile as sf

sf.write("test.wav", np.zeros((1000, 2)), 44100)

fd = os.open("test.wav", os.O_RDONLY)
f = sf.SoundFile(fd)
f.close()

try:
    os.lseek(fd, 0, os.SEEK_SET)
    print("fd is STILL OPEN")
except OSError as e:
    print(f"fd is closed — got {e}")

Output:

fd is closed — got [Errno 9] Bad file descriptor

So the FD is definitely closed, but os.close(fd) doesn’t raise on this environment.

If you prefer, we could keep the check and disable it only on Windows.