Update typing for Python 3.10 and enhance configuration#476
Open
hunterhogan wants to merge 2 commits intobastibe:masterfrom
Open
Update typing for Python 3.10 and enhance configuration#476hunterhogan wants to merge 2 commits intobastibe:masterfrom
hunterhogan wants to merge 2 commits intobastibe:masterfrom
Conversation
Based on https://github.com/hunterhogan/stubFileNotFound/blob/25b460289cb3fd331e1a8872af11ee8a1c3fa19a/stubs/soundfile.pyi pyrightconfig.json "The exclude list is missing default excludes such as '**/.*'. Consider adding them to avoid analyzing unnecessary files." - added `"**/.*"`. Python 3.9 is EOL. - change to `"pythonVersion": "3.10"`. - Add rules soundfile.py - ran `pyupgrade --py310-plus soundfile.py` - added overload The overload definitions only focus on `always_2d`.
Owner
|
Thank you for the contribution, but this seems to fail our tests |
Author
All checks failedThat's impressive, but in the wrong way. Updated types, new GitHub knowledgeBy coincidence, last week, I revamped my soundfile stub file. Since it is written with Py 3.10 notation, I think it will fail the pypy 3.7 tests, but I've never used pypy, so I could be wrong. Also by coincidence, I've learned from some advice in other PRs how to make a PR that is easier to review. I am motivated to see this updated
Plan?I could write a new PR that is easier to review. I would need to work on it for three to five hours. Would a new PR written for Python >= 3.10 be useful to you? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the project to Python 3.10, add necessary typing rules, and improve the configuration by including default excludes to optimize file analysis. Overload definitions in
soundfile.pyfocus onalways_2d.