Skip to content

Make LZ4 test optional#92

Closed
ericonr wants to merge 2 commits intoareaDetector:masterfrom
ericonr:optional-lz4-test
Closed

Make LZ4 test optional#92
ericonr wants to merge 2 commits intoareaDetector:masterfrom
ericonr:optional-lz4-test

Conversation

@ericonr
Copy link
Copy Markdown
Member

@ericonr ericonr commented Apr 7, 2026

Building it requires LZ4 as a system library, which is not guaranteed to be available. #91 kind of fixes that, but I believe building and installing it should still be optional.

ericonr added 2 commits April 7, 2026 11:06
This file is not part of the IOC logic itself and is used to test
decompression within the IOC.
These won't be used by the majority of IOC users, and, at least for now,
complicate the build by including lz4 in SYS_LIBS.
@ericonr ericonr requested a review from MarkRivers April 7, 2026 14:16
@MarkRivers
Copy link
Copy Markdown
Member

This PR is no longer needed. test_lz4 has been removed in the new version of #91.

The new version of #91 also removes eigerApp/compressionSrc, since that is also no longer needed.

@MarkRivers MarkRivers closed this Apr 7, 2026
@ericonr ericonr deleted the optional-lz4-test branch April 8, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants