RequestProcessor warning fixes and minor update#9330
Draft
mbien wants to merge 1 commit intoapache:masterfrom
Draft
RequestProcessor warning fixes and minor update#9330mbien wants to merge 1 commit intoapache:masterfrom
mbien wants to merge 1 commit intoapache:masterfrom
Conversation
- use SortedSet#removeFirst instead of getFirst()+remove() - remove ThreadDeath and AccessController.doPrivileged() usage - convert Maps of type WeakHashMap to Set where applicable - generics rawtype warning fixes, diamonds, overrides and similar minor renovations - javadoc typos
mbien
added
Code cleanup
eirikbakke
approved these changes
Apr 11, 2026
Contributor
eirikbakke
left a comment
eirikbakke
left a comment
There was a problem hiding this comment.
Straightforward cleanup. The "implements PrivilegedAction" stuff was related to long-removed workarounds for JNLP and Applet environments. Thanks!
mbien
commented
Apr 11, 2026
| } | ||
| Callable<T> delegate = new WaitableCallable<T>(c, wait); | ||
| Objects.requireNonNull(c, "Contains null tasks: " + tasks); //NOI18N | ||
| Callable<T> delegate = new WaitableCallable<>(c, wait); |
Member
Author
There was a problem hiding this comment.
requireNonNull() was not a good idea since it will concat the string every time now. Will revert those changes and check the diff again. Those where from a jackpot script where I didn't check if the right hand side was constant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SortedSet#removeFirstinstead ofgetFirst()+remove()ThreadDeathandAccessController.doPrivileged()usageMapsof typeWeakHashMaptoSetwhere applicablelow priority, can wait for NB 31 unless it gets a review in time