HBASE-30058 Eliminate unnecessary connection creation in snapshot operations#8030
Open
mini666 wants to merge 1 commit intoapache:masterfrom
Open
HBASE-30058 Eliminate unnecessary connection creation in snapshot operations#8030mini666 wants to merge 1 commit intoapache:masterfrom
mini666 wants to merge 1 commit intoapache:masterfrom
Conversation
…rations Each snapshot operation created two short-lived connections in SnapshotDescriptionUtils.validate() — one for isSecurityAvailable() to check hbase:acl table existence, and another in writeAclToSnapshotDescription() to read ACL data. In Kerberos environments with ZKConnectionRegistry, each connection triggered a new ZK session with GSSAPI authentication and a TGS request to the KDC, causing excessive KDC load during batch snapshot operations. This patch reuses the caller's existing connection instead of creating new ones: - isSecurityAvailable() now accepts a Connection parameter - writeAclToSnapshotDescription() passes the shared connection's Table to PermissionStorage.getTablePermissions() - All callers (MasterRpcServices, RestoreSnapshotProcedure, CloneSnapshotProcedure) pass through their available connection Signed-off-by: JeongMin Ju <mini666@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Each snapshot operation created two short-lived connections in
SnapshotDescriptionUtils.validate():isSecurityAvailable(conf)— created aConnection+Adminjust to checkhbase:acltable existencewriteAclToSnapshotDescription()— created anotherConnectionto read ACL data fromhbase:aclIn Kerberos environments with the default
ZKConnectionRegistry, each connection triggered a new ZK session with GSSAPI authentication and a TGS request to the KDC. During batch snapshot operations, this caused excessive KDC load that could lead to IP blocking.This patch reuses the caller's existing connection instead of creating new ones:
isSecurityAvailable()now accepts aConnectionparameterwriteAclToSnapshotDescription()passes the shared connection'sTabletoPermissionStorage.getTablePermissions()MasterRpcServices,RestoreSnapshotProcedure,CloneSnapshotProcedure) pass through their available connectionZero behavioral change — the same checks are performed, the same data is read, the same ACL is written to snapshots.
See HBASE-30058 for detailed root cause analysis including design ambiguity discussion.