test: Add datafusion.format.* configs test coverage#21355
Open
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Open
test: Add datafusion.format.* configs test coverage#21355erenavsarogullari wants to merge 1 commit intoapache:mainfrom
erenavsarogullari wants to merge 1 commit intoapache:mainfrom
Conversation
alamb
approved these changes
Apr 4, 2026
Contributor
alamb
left a comment
alamb
left a comment
There was a problem hiding this comment.
Thanks @erenavsarogullari -- I think these are nice improvements in coverage. It would be even nicer to get some functional coverage too if they don't yet exist
| ## Test datafusion.format.* configurations ## | ||
| ############################################# | ||
| query T | ||
| SELECT name FROM information_schema.df_settings WHERE name LIKE 'datafusion.format.%' ORDER BY name |
Contributor
There was a problem hiding this comment.
In addition to tests showing that they can be set/removed, how about also adding tests that run a function that is affected by them (e.g. select a date and then show that changing datafusion.format.date changes how they are displayed)?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
datafusion.format.*configs test coverage #21354.Rationale for this change
Currently, DataFusion supports 9
datafusion.format.*configs but their test coverage seem to be missed so this issue aims to add comprehensive test coverage for them. This is follow-up to recentconfig frameworkimprovements: #20372 and #20816.What changes are included in this PR?
New test coverage is being added for
datafusion.format.*configs.Are these changes tested?
Yes, new test coverage is being added for
datafusion.format.*configs.Are there any user-facing changes?
No