Skip to content

Create volume on a specified storage pool#12966

Open
abh1sar wants to merge 1 commit intoapache:4.22from
shapeblue:create-vol-on-stroage
Open

Create volume on a specified storage pool#12966
abh1sar wants to merge 1 commit intoapache:4.22from
shapeblue:create-vol-on-stroage

Conversation

@abh1sar
Copy link
Copy Markdown
Contributor

@abh1sar abh1sar commented Apr 6, 2026

Description

This PR adds support for creating volume on the specified storage pool in the Ready state.
This can be done without attaching the volume to any instance. This can be helpful with vmware2kvm scenarios.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Created volume using the storageid parameter on an NFS storage pool.
Verified that volume was in Ready state with a qcow2 file created with the specified virtual size.

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Apr 6, 2026

Codecov Report

❌ Patch coverage is 12.50000% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.00%. Comparing base (59b6c32) to head (30ee7e2).
⚠️ Report is 3 commits behind head on 4.22.

Files with missing lines Patch % Lines
...n/java/com/cloud/storage/VolumeApiServiceImpl.java 18.18% 9 Missing ⚠️
...stack/api/command/user/volume/CreateVolumeCmd.java 0.00% 5 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               4.22   #12966      +/-   ##
============================================
+ Coverage     17.60%   18.00%   +0.39%     
- Complexity    15676    16463     +787     
============================================
  Files          5918     5977      +59     
  Lines        531667   537742    +6075     
  Branches      65001    66028    +1027     
============================================
+ Hits          93617    96834    +3217     
- Misses       427491   429990    +2499     
- Partials      10559    10918     +359     
Flag Coverage Δ
uitests 3.52% <ø> (-0.18%) ⬇️
unittests 19.17% <12.50%> (+0.49%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@abh1sar abh1sar changed the base branch from main to 4.22 April 6, 2026 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants