Optimize batch-read to avoid wasted disk IO#4741
Open
dao-jun wants to merge 4 commits intoapache:masterfrom
Open
Optimize batch-read to avoid wasted disk IO#4741dao-jun wants to merge 4 commits intoapache:masterfrom
dao-jun wants to merge 4 commits intoapache:masterfrom
Conversation
eolivelli
requested changes
Apr 13, 2026
Contributor
eolivelli
left a comment
There was a problem hiding this comment.
I can't find tests about failure scenarios.
Memory leaks can happen in case of failures (reading from storage...), client may see the wrong error code.....
Member
Author
|
@eolivelli I added 3 tests in BatchedReadEntryProcessorTest, PTAL |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Batch reads currently fetch the next entry before checking whether it can still fit within the maxSize budget. When the last entry in the batch exceeds the remaining space, the read result is discarded, but the disk IO has already happened. This creates wasted IO on the critical read path.
This change avoids that extra read while preserving the existing batch-read behavior, including returning the first entry even when a single entry alone exceeds the requested maxSize.
Changes