Allow SpannerIO.readChangeStream() to query & union a list of change stream TVF's#38167
Allow SpannerIO.readChangeStream() to query & union a list of change stream TVF's#38167tianz101 wants to merge 1 commit intoapache:masterfrom
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces functionality to allow SpannerIO to query and union multiple change stream TVFs. This change involves updating the partition metadata model to track TVF names, modifying the data access layer to handle composed partition tokens, and updating the SpannerIO read pipeline to support these new configurations. Additionally, necessary dependency updates were made to support the latest Spanner libraries. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces support for querying multiple Table Valued Functions (TVFs) within Spanner change streams, specifically for the MUTABLE_KEY_RANGE partition mode. Key changes include updating SpannerIO to accept a list of TVF names, modifying PartitionMetadata to store TVF associations, and adjusting the DAO and action layers to handle composed partition tokens that include TVF names. Review feedback focuses on critical security concerns regarding SQL injection risks when concatenating TVF names into queries and suggests using parameterized queries or more robust identifier escaping mechanisms.
...form/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamDao.java
Show resolved
Hide resolved
...form/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/dao/ChangeStreamDao.java
Show resolved
Hide resolved
| public static String escapeTvfName(String tvfName) { | ||
| return tvfName.replace("'", "").replace("\"", ""); | ||
| } |
There was a problem hiding this comment.
The escapeTvfName method is destructive as it removes all single and double quotes from the TVF name. This will cause validation and queries to fail if a TVF name legitimately contains these characters (e.g., delimited identifiers in Spanner). Instead of removing these characters, the code should handle them by using proper quoting when the name is used in SQL queries. Additionally, this simple replacement is not a robust way to prevent SQL injection.
...ava/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/SpannerIO.java
Outdated
Show resolved
Hide resolved
|
Checks are failing. Will not request review until checks are succeeding. If you'd like to override that behavior, comment |
Please add a meaningful description for your change here
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>instead.CHANGES.mdwith noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.