multiple entries where second is intersecting#113
Open
abhishek-031 wants to merge 1 commit intoalexjoverm:masterfrom
Open
multiple entries where second is intersecting#113abhishek-031 wants to merge 1 commit intoalexjoverm:masterfrom
abhishek-031 wants to merge 1 commit intoalexjoverm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposing a fix for issue #112
Earlier the observer callback was only checking if the first entry is intersecting with the viewport but in some cases there can be multiple entries in the callback where the code only checks for the first one and if the first one is false and any other is true the code breaks.
Trying to check if any entry is intersecting is a viable solution to fix this.
Attaching a screen shot of the console reproducing the issue.