Conversation
There was a problem hiding this comment.
Pull request overview
This PR is intended to address #84 (“logLevel/logFormat not respected; plain-text [DEBUG] GET ... logs emitted”) by ensuring the configured logger is propagated down to the underlying retryablehttp.Client instead of using its default logger.
Changes:
- Adds
TestWithLoggersubtests to validateWithLogger(nil)and custom logger behavior onhttpClientOption. - Adds tests intended to validate logger propagation to both built-in and custom retryable HTTP clients, including order-invariance for option application.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
d677796 to
9418c22
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Fixes #84