Skip to content

Fix logger propagation#85

Open
nikola-jokic wants to merge 2 commits intomainfrom
nikola-jokic/fix-logger
Open

Fix logger propagation#85
nikola-jokic wants to merge 2 commits intomainfrom
nikola-jokic/fix-logger

Conversation

@nikola-jokic
Copy link
Copy Markdown
Collaborator

Fixes #84

@nikola-jokic nikola-jokic requested a review from a team as a code owner March 31, 2026 14:45
Copilot AI review requested due to automatic review settings March 31, 2026 14:45
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is intended to address #84 (“logLevel/logFormat not respected; plain-text [DEBUG] GET ... logs emitted”) by ensuring the configured logger is propagated down to the underlying retryablehttp.Client instead of using its default logger.

Changes:

  • Adds TestWithLogger subtests to validate WithLogger(nil) and custom logger behavior on httpClientOption.
  • Adds tests intended to validate logger propagation to both built-in and custom retryable HTTP clients, including order-invariance for option application.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The logLevel property is not respected and non json debug logs are showing 0.14.0

2 participants