Conversation
When callers narrow review scope to a specific file set (via run_review files= or get_configured_reviews only_rules_matching_files=), rules whose include patterns are all pure wildcards (*, **, **/*, */**) are now dropped — they rarely reflect caller intent and produce noisy results. Rules with any literal path segment are kept. Catch-all rules remain in effect when scope comes from git diff. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_review(files=...)orget_configured_reviews(only_rules_matching_files=...)), rules whose include patterns are all pure wildcards (*,**,**/*,*/**) are now dropped. Rules with any literal path segment are kept. Catch-all rules remain in effect when scope comes from git diff.doc/architecture.mddescription ofget_configured_reviewsto mention DeepSchema-generated rules and the new catch-all filtering.Test plan
uv run pytest tests/unit/review/test_mcp.py(36 passed, 100% coverage onreview/mcp.py)make lintclean🤖 Generated with Claude Code