Feature: Add nan support for curved_quiver#676
Merged
cvanelteren merged 4 commits intomainfrom Apr 7, 2026
Merged
Conversation
…hard failures so vector fields with gaps still render cleanly. This updates the trajectory solver to stop gracefully at invalid samples, hardens arrow construction around masked endpoints, and adds regression coverage for both solver-level and plotting-level NaN cases.
…n to the plotting layer so NaN handling stays encapsulated where the trajectories are computed. The end-arrow path now uses the final streamline segment as its tangent, which removes the extra endpoint resampling and keeps the public plotting code out of the solver's internal control flow.
…trajectory result object instead of leaking tuple-shaped internal state into the plotting layer. This keeps endpoint direction and edge handling with the integration code, simplifies the renderer, and adds assertions that the solver now exposes the metadata the plot path actually consumes.
…when its streamline colors come from array data, so it behaves like the other color-mapped field plots. This adds the familiar colorbar arguments to the method signature, documents that they apply to array-valued colors, and verifies that the created colorbar is registered against the streamline LineCollection with the requested label.
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add nan support + tests for curved quiver.
EDIT: also threw in colorbar support natively.
Closes #675