Add explicit node types for TypeScript 6 compat#51
Merged
Conversation
TypeScript 6.0 changed the default types behavior so node types are no longer auto-included. This fixes builds in projects that use TS 6. Made-with: Cursor
There was a problem hiding this comment.
Pull request overview
Updates the @socketsecurity/socket-patch TypeScript project config to explicitly include Node.js ambient type definitions, aligning the package with TypeScript 6’s changed default behavior for automatic @types/* inclusion and keeping project-reference builds working for depscan.
Changes:
- Add
"types": ["node"]tonpm/socket-patch/tsconfig.jsonto ensure Node globals/types are available during compilation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Wenxin-Jiang
approved these changes
Apr 2, 2026
Raynos
added a commit
that referenced
this pull request
Apr 6, 2026
TypeScript 6.0 changed the default types behavior so node types are no longer auto-included. This fixes builds in projects that use TS 6. Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
"types": ["node"]tonpm/socket-patch/tsconfig.jsontypesbehavior so node types are no longer auto-includedBased on v2.0.0 so depscan can consume it without lockfile changes.
Context
SocketDev/depscan#18896 is upgrading depscan to TypeScript 6.0.2.
Test plan
tsc -b npm/socket-patchstill builds successfullyMade with Cursor