fix(ci): remove npm upgrade hack from provenance workflow#1162
Closed
fix(ci): remove npm upgrade hack from provenance workflow#1162
Conversation
Contributor
Author
|
Folded into #1161 (SHA bump + npm hack removal combined) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 25.8.2 (.node-version) ships npm 11.11+. The curl+tar npm upgrade step is unnecessary.
Note
Low Risk
Low risk: this only removes a CI workaround step and relies on the Node-provided npm during the publish workflow. Main risk is publish failures if the runner’s bundled npm lacks required trusted publishing/provenance behavior.
Overview
Removes the custom
curl | tarnpm self-upgrade step from theprovenance.ymlpublish workflow, so publishing now uses the npm version bundled with the Node version from.node-version.This simplifies the build/publish jobs and avoids mutating the global npm installation mid-workflow.
Reviewed by Cursor Bugbot for commit 9cd7b27. Configure here.