Fix output for 16-bit targets#1470
Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom Apr 9, 2026
Merged
Conversation
`tokens32` being used for both 16 and 32 bits appears to be an artifact from copying the prior block and modifying it (as reasonable for such development), but itself unsound.
Contributor
Author
|
CI passing is always a good sign 🎉 I caught this while beginning working on a |
tarcieri
approved these changes
Apr 9, 2026
Member
tarcieri
left a comment
tarcieri
left a comment
There was a problem hiding this comment.
Thanks! Unfortunately I wasn’t able to figure out a good solution for 16-bit CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tokens32being used for both 16 and 32 bits appears to be an artifact from copying the prior block and modifying it (as reasonable for such development), but itself unsound.I used the web UI for this, just to fire this off quickly as an exceptionally minor change, but that does mean it's completely untested.