Add materialization_embeddings option to materialization API#83
Merged
Add materialization_embeddings option to materialization API#83
Conversation
…aterializeRequest - Introduced a new boolean field `materialize_embeddings` in `MaterializationOptions` to control the inclusion of embedding columns during materialization. - Updated `MaterializeRequest` to support the new `materialize_embeddings` field, allowing for the creation of HNSW vector indexes in the graph database when set to true. - Adjusted the `to_dict` and `from_dict` methods in `MaterializeRequest` to handle the new field appropriately. These changes enhance the materialization process by providing more control over embedding data handling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces a new
materialization_embeddingsoption to the materialization pipeline, allowing clients to control whether embeddings are materialized as part of a materialization request.Key Changes
MaterializationOptions: Added a newmaterialization_embeddingsboolean field (defaulting toFalse) to the options model, giving users fine-grained control over embedding materialization behavior.MaterializeRequest: Extended the request model with the correspondingmaterialization_embeddingsparameter, ensuring it is properly propagated through the request payload.MaterializationClient: Updated the client extension to pass thematerialization_embeddingsoption fromMaterializationOptionsinto theMaterializeRequestconstruction, wiring the full flow end-to-end.Breaking Changes
None. The new field defaults to
False, preserving existing behavior for all current consumers. This is a purely additive, backwards-compatible change.Testing Notes
Falsebehavior).materialization_embeddings=TrueinMaterializationOptionscorrectly includes the flag in the outgoingMaterializeRequestpayload.Infrastructure Considerations
materialization_embeddingsfield in the materialization endpoint; otherwise, the parameter may be silently ignored or cause validation errors depending on the server's strictness.🤖 Generated with Claude Code
Branch Info:
feature/materialize-embeddingsmainCo-Authored-By: Claude noreply@anthropic.com