Only pull relevant keys for caching FlowContext#193
Draft
NeejWeej wants to merge 2 commits intonk/auto_deps_auto_callable_modelfrom
Draft
Only pull relevant keys for caching FlowContext#193NeejWeej wants to merge 2 commits intonk/auto_deps_auto_callable_modelfrom
NeejWeej wants to merge 2 commits intonk/auto_deps_auto_callable_modelfrom
Conversation
Signed-off-by: Nijat Khanbabayev <nijat.khanbabayev@cubistsystematic.com>
NeejWeej
requested review from
feussy,
hintse,
ptomecek and
timkpaine
as code owners
Contributor
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## nk/auto_deps_auto_callable_model #193 +/- ##
====================================================================
+ Coverage 95.04% 95.11% +0.06%
====================================================================
Files 144 144
Lines 11410 11619 +209
Branches 737 754 +17
====================================================================
+ Hits 10845 11051 +206
- Misses 399 400 +1
- Partials 166 168 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the new functional syntax, @Flow.model decorated functions specify what arguments they pull from the context, but at runtime, a large "bag of context" FlowContext is provided. For correctness of the cache, this PR restricts the context arguments used for caching to be only the ones requested by each model (and it's dependencies).
This helps avoid the issue where an unrelated context parameter inside a
FlowContextis used to cache a model.Type of Change
Checklist
make lint)make test)