Fix traceback formatting in permutation_lib.py#1987
Open
yujincheng08 wants to merge 2 commits intoNVIDIA:masterfrom
Open
Fix traceback formatting in permutation_lib.py#1987yujincheng08 wants to merge 2 commits intoNVIDIA:masterfrom
yujincheng08 wants to merge 2 commits intoNVIDIA:masterfrom
Conversation
Python 3.10+ no longer supports etype.
for more information, see https://pre-commit.ci
Contributor
There was a problem hiding this comment.
Pull request overview
Updates exception traceback printing when Torch.FX symbolic tracing fails in apex.contrib.sparsity utilities.
Changes:
- Simplifies the traceback formatting call in
trace_and_print_raw_fx_graphwhensymbolic_trace(model)raises.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Comment on lines
2011
to
2013
| print(ex) | ||
| print( | ||
| "".join( | ||
| traceback.format_exception( | ||
| etype=type(ex), value=ex, tb=ex.__traceback__ | ||
| ) | ||
| ) | ||
| ) | ||
| print("".join(traceback.format_exception(value=ex, tb=ex.__traceback__))) | ||
| print( |
Author
There was a problem hiding this comment.
hmm, this may cause inconsistency. And since python 3.6 etype has no effect.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.10+ no longer supports etype: