Fix build system for windows targets#38
Open
RobbieG15 wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Open
Fix build system for windows targets#38RobbieG15 wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
RobbieG15 wants to merge 1 commit intoNVIDIA-ISAAC-ROS:mainfrom
Conversation
Greptile SummaryWraps the Confidence Score: 5/5Safe to merge — minimal, correct compatibility fix with no logic impact on non-Windows platforms Single targeted change, no P0/P1 findings, fix is well-understood and correct per C++ standard No files require special attention Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GetTimestampFromSerializedMessage] --> B[Read sec bytes from buffer]
B --> C[Read nanosec bytes from buffer]
C --> D[chrono::seconds + chrono::nanoseconds]
D --> E{Platform system_clock::duration}
E -->|Linux/macOS - nanoseconds| F[No-op cast]
E -->|Windows/MSVC - 100ns ticks| G[Truncating cast via duration_cast]
F --> H[Construct time_point]
G --> H
Reviews (1): Last reviewed commit: "Fix build system for windows targets" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will fix windows build systems.
There is a stricter usage of Chrono with windows and MSVC.
Thank you for all the work on this project.
Let me know if there is anything else I can do if this does not fix it for you all.
I verified that this works on my windows machine.