Open
Conversation
| inv_vref_tgt[0] = fitter_l0.fit(target_adc); | ||
| inv_vref_tgt[1] = fitter_l1.fit(target_adc); | ||
| break; | ||
| } catch (...) { |
Member
There was a problem hiding this comment.
Please add a specific type to the exception you are catching. As written, we could (for example) have a bug in DataFitter that is causing an std::out_of_range exception but we are treating that like a "bad fit" exception. I would like DataFitter to be updated to be able to inform the user when the fit fails (what exception is being thrown when a fit "fails"?)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds noinv_vref alignment to existing inv_vref alignment. Caught by bad fits and boundary cases.