Extend "get collection" use case to return theme#417
Open
vera wants to merge 1 commit intoIQSS:developfrom
Open
Extend "get collection" use case to return theme#417vera wants to merge 1 commit intoIQSS:developfrom
vera wants to merge 1 commit intoIQSS:developfrom
Conversation
scolapasta
moved this from Ready for Triage
to Ready for Review ⏩
in IQSS Dataverse Project
ChengShi-1
reviewed
Apr 3, 2026
Contributor
ChengShi-1
left a comment
ChengShi-1
left a comment
There was a problem hiding this comment.
Thanks for you contribution! This is really good. Could you also update the following?
- changelog.md
- integration test
- unit test
ChengShi-1
reviewed
Apr 3, 2026
|
|
||
| export interface CollectionTheme { | ||
| id: number | ||
| logo: string |
Contributor
There was a problem hiding this comment.
After reviewing the backend, it appears that they are all optional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR extends the "Get a collection" use case to also return its theme info, which is returned by the Dataverse API.
Which issue(s) this PR closes:
/
Related Dataverse PRs:
/
Special notes for your reviewer:
/
Suggestions on how to test this:
Use
getCollection.execute(collectionId)to read a collection. If it has a theme configured, e.g. a logo, that should be returned as part of the response.Is there a release notes or changelog update needed for this change?:
Yes
Additional documentation:
/