[INFRANG-7812] implement deploy-apps command to support slingshot deploys#191
Open
dmartschenko wants to merge 3 commits intomasterfrom
Open
[INFRANG-7812] implement deploy-apps command to support slingshot deploys#191dmartschenko wants to merge 3 commits intomasterfrom
dmartschenko wants to merge 3 commits intomasterfrom
Conversation
jakegut
reviewed
Apr 7, 2026
andruwm
reviewed
Apr 8, 2026
Comment on lines
+11
to
+12
| appStackConfigPath = "config/%s/stack.yaml" | ||
| appValuesConfigPath = "config/%s/values.yaml" |
Contributor
There was a problem hiding this comment.
Should these be regex strings since values can have multiple variants?
Author
There was a problem hiding this comment.
These are templates and the app is injected into the string. From what I understand we're expecting a common structure for the config directory
Contributor
There was a problem hiding this comment.
Yes, common config directory, but there can be multiple values.yaml. i.e., development-values.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clever Coding Standards Agreement
JIRA
https://clever.atlassian.net/browse/INFRANG-7812
About
Add a new deploy-apps command to support slingshot deploys.
To call Slingshot directly from CircleCI using Twingate, the job needs to run on a linux machine executor not a docker executor. CircleCi docker executors do not support tunneling. However, machine executors are more expensive than docker executors, therefore rather than running the entire build/publish/deploy job on the machine executors I opted to create a new deploy-app job that can be configured to only run if the branch is master. The goal is to keep the additional cost minimal.
The vast majority of the circle-ci runs are for non-master branches so the additional cost will be applicable to a limited number of runs.
Checklist
Testing
INFRANG-7812in this repo