Skip to content

[PWGUD] use get track size and add flowMC#15679

Open
miedema-11 wants to merge 5 commits intoAliceO2Group:masterfrom
miedema-11:master
Open

[PWGUD] use get track size and add flowMC#15679
miedema-11 wants to merge 5 commits intoAliceO2Group:masterfrom
miedema-11:master

Conversation

@miedema-11
Copy link
Copy Markdown
Contributor

@miedema-11 miedema-11 commented Apr 8, 2026

No description provided.

@github-actions github-actions bot added the pwgud label Apr 8, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 8, 2026 •
edited
Loading

O2 linter results: ❌ 1 errors, ⚠️ 2 warnings, 🔕 4 disabled

@github-actions github-actions bot changed the title use get track size and add flowMC [PWGUD] use get track size and add flowMC Apr 8, 2026
@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Apr 8, 2026

Error while checking build/O2Physics/o2 for 4eeefde at 2026-04-08 08:43:

## sw/BUILD/O2Physics-latest/log
/sw/SOURCES/O2Physics/slc9_x86-64-slc9_x86-64/0/PWGUD/Tasks/flowCorrelationsUpc.cxx:385:10: error: variable 'getTracksSize' set but not used [-Werror=unused-but-set-variable]
ninja: build stopped: subcommand failed.

Full log here.

amatyja
amatyja previously approved these changes Apr 8, 2026
View reviewed changes
@vkucera
Copy link
Copy Markdown
Collaborator

vkucera commented Apr 8, 2026

@miedema-11 This is a duplicate of #15626. Please do not do that. I made several suggestions on your previous PR which are now completely disconnected from this version and I have to visually compare both versions to see your implementation of my comments.

vkucera
vkucera reviewed Apr 8, 2026
View reviewed changes
PWGUD/Tasks/flowMcUpc.cxx Outdated
Comment on lines +191 to +207
auto mcParticle = track.udMcParticle();
int pdgCode = std::abs(mcParticle.pdgCode());
if (pdgCode == PDG_t::kElectron)
recoMC.SetM(o2::constants::physics::MassElectron);
else if (pdgCode == PDG_t::kMuonMinus)
recoMC.SetM(o2::constants::physics::MassMuon);
else if (pdgCode == PDG_t::kPiPlus)
recoMC.SetM(o2::constants::physics::MassPionCharged);
else if (pdgCode == PDG_t::kKPlus)
recoMC.SetM(o2::constants::physics::MassKaonCharged);
else if (pdgCode == PDG_t::kProton)
recoMC.SetM(o2::constants::physics::MassProton);
else
continue;

double pt = recoMC.Pt();
double eta = recoMC.Eta();
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same

@amatyja
Copy link
Copy Markdown
Collaborator

amatyja commented Apr 8, 2026

Hi @miedema-11,
Incorporate the corrections suggested by Vit, please.
Best regards
Adam

@miedema-11
Copy link
Copy Markdown
Contributor Author

miedema-11 commented Apr 9, 2026

@miedema-11 This is a duplicate of #15626. Please do not do that. I made several suggestions on your previous PR which are now completely disconnected from this version and I have to visually compare both versions to see your implementation of my comments.

Not exactly, I also modify the flowcorrelationupc.cxx, so I open a new one to avoid conflict. And I already corrected the code according to your comment. Maybe I haven't done it correctly?

vkucera
vkucera reviewed Apr 9, 2026
View reviewed changes
amatyja
amatyja previously approved these changes Apr 9, 2026
View reviewed changes
vkucera
vkucera reviewed Apr 9, 2026
View reviewed changes
PWGUD/Tasks/flowMcUpc.cxx Outdated
using namespace o2;
using namespace o2::framework;
using namespace o2::framework::expressions;
using LorentzVectorM = ROOT::Math::LorentzVector<ROOT::Math::PxPyPzM4D<double>>;
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unused

vkucera
vkucera reviewed Apr 9, 2026
View reviewed changes
PWGUD/Tasks/flowMcUpc.cxx Outdated
Comment on lines +38 to +39
#include <TProfile.h>
#include <TRandom3.h>
Copy link
Copy Markdown
Collaborator

@vkucera vkucera Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where do you use these headers?

@miedema-11
Copy link
Copy Markdown
Contributor Author

miedema-11 commented Apr 10, 2026

Dear experts,
Thank you both for reviewing my codes and making it perform better. But since this PR has been opened for a long time, could we save further improvements for next time and merge it this time?
Thank you again for your support.
Best regards,
Yongxi Du

@amatyja
Copy link
Copy Markdown
Collaborator

amatyja commented Apr 10, 2026

Hi @miedema-11,
The PR is almost fine. I will approve it and merge it. However, with the next occasion remove or comment out LorentzVectorM and #include <TRandom3.h>. It is just to reduce memory consumption.
Best regards
Adam

@amatyja amatyja enabled auto-merge (squash) April 10, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vkucera vkucera vkucera left review comments

@amatyja amatyja amatyja left review comments

@alibuild alibuild Awaiting requested review from alibuild alibuild is a code owner

@rolavick rolavick Awaiting requested review from rolavick rolavick is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

pwgud

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@miedema-11 @alibuild @vkucera @amatyja