Skip to content

[Tutorial,PWGCF,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes and using statements#15392

Merged
vkucera merged 1 commit intoAliceO2Group:masterfrom
vkucera:fixes-Tutorials
Apr 14, 2026
Merged

[Tutorial,PWGCF,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes and using statements#15392
vkucera merged 1 commit intoAliceO2Group:masterfrom
vkucera:fixes-Tutorials

Conversation

@vkucera
Copy link
Copy Markdown
Collaborator

@vkucera vkucera commented Mar 13, 2026

No description provided.

@alibuild alibuild mentioned this pull request Mar 13, 2026
Merged
@github-actions github-actions bot changed the title Fix includes and using statements [Tutorial,PWGCF,PWGEM,PWGHF,PWGLF,PWGMM,PWGUD] Fix includes and using statements Mar 13, 2026
vkucera pushed a commit to vkucera/O2Physics that referenced this pull request Mar 13, 2026
@alibuild
Please consider the following formatting changes to AliceO2Group#15392 (
e1bd030 
#145)
@vkucera vkucera force-pushed the fixes-Tutorials branch 4 times, most recently from 5738941 to 94873fc Compare March 26, 2026 09:43
This was referenced Mar 26, 2026
Open
Open
@vkucera vkucera marked this pull request as ready for review March 26, 2026 15:03
@ktf
Copy link
Copy Markdown
Member

ktf commented Mar 26, 2026

i think there is too much headers pulled in for the framework. we need to review this.

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Mar 26, 2026 •
edited
Loading

i think there is too much headers pulled in for the framework. we need to review this.

That means adding // IWYU pragma: export in the wrapper headers.
I'm happy to do the cleanup once we do that.

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented Mar 26, 2026 •
edited
Loading

Error while checking build/O2Physics/o2 for f6e2a6b at 2026-04-08 05:27:

## sw/BUILD/O2Physics-latest/log
c++: fatal error: Killed signal terminated program cc1plus
ninja: build stopped: subcommand failed.

Full log here.

@amatyja amatyja enabled auto-merge (squash) March 28, 2026 14:00
@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Mar 31, 2026

Dear code owners, can you please review and approve the PR?

amatyja
amatyja approved these changes Mar 31, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@amatyja amatyja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, UD is fine.

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 7, 2026

@aalkin @ddobrigk @jgrosseo @victor-gonzalez @zchochul can you please review and approve the PR?

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 9, 2026

@aalkin @ddobrigk @victor-gonzalez @zchochul Ping

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 10, 2026

@aalkin @ddobrigk @victor-gonzalez @zchochul Ping 2

@vkucera
Copy link
Copy Markdown
Collaborator Author

vkucera commented Apr 13, 2026

@aalkin @ddobrigk @victor-gonzalez @zchochul Ping 3

@vkucera vkucera disabled auto-merge April 14, 2026 18:18
@vkucera vkucera enabled auto-merge (squash) April 14, 2026 18:18
alibuild
alibuild approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@alibuild alibuild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Auto-approving on behalf of @vkucera.

@vkucera vkucera merged commit 9ad38d0 into AliceO2Group:master Apr 14, 2026
18 of 20 checks passed
@vkucera vkucera deleted the fixes-Tutorials branch April 14, 2026 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@victor-gonzalez victor-gonzalez victor-gonzalez approved these changes

@alibuild alibuild alibuild approved these changes

@amatyja amatyja amatyja approved these changes

@ivorobye ivorobye ivorobye approved these changes

@ddobrigk ddobrigk ddobrigk approved these changes

@dsekihat dsekihat dsekihat approved these changes

@romainschotter romainschotter romainschotter approved these changes

@pbuehler pbuehler Awaiting requested review from pbuehler pbuehler is a code owner

@aalkin aalkin Awaiting requested review from aalkin aalkin is a code owner

@alcaliva alcaliva Awaiting requested review from alcaliva alcaliva is a code owner

@lbariogl lbariogl Awaiting requested review from lbariogl lbariogl is a code owner

@chiarapinto chiarapinto Awaiting requested review from chiarapinto chiarapinto is a code owner

@BongHwi BongHwi Awaiting requested review from BongHwi BongHwi is a code owner

@lbarnby lbarnby Awaiting requested review from lbarnby lbarnby is a code owner

@ercolessi ercolessi Awaiting requested review from ercolessi ercolessi is a code owner

@iravasen iravasen Awaiting requested review from iravasen iravasen is a code owner

@njacazio njacazio Awaiting requested review from njacazio njacazio is a code owner

@skundu692 skundu692 Awaiting requested review from skundu692 skundu692 is a code owner

@lhusova lhusova Awaiting requested review from lhusova lhusova is a code owner

@fcolamar fcolamar Awaiting requested review from fcolamar fcolamar is a code owner

@fgrosa fgrosa Awaiting requested review from fgrosa fgrosa is a code owner

@gluparel gluparel Awaiting requested review from gluparel gluparel is a code owner

@mikesas mikesas Awaiting requested review from mikesas mikesas is a code owner

@rbailhac rbailhac Awaiting requested review from rbailhac rbailhac is a code owner

@feisenhu feisenhu Awaiting requested review from feisenhu feisenhu is a code owner

@jgrosseo jgrosseo Awaiting requested review from jgrosseo jgrosseo is a code owner

@zchochul zchochul Awaiting requested review from zchochul zchochul is a code owner

@iarsene iarsene Awaiting requested review from iarsene iarsene is a code owner

@ktf ktf Awaiting requested review from ktf ktf is a code owner

Assignees

No one assigned

Labels

datamodel pwgcf pwgem pwghf PWG-HF pwglf pwgmm pwgud tutorial

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@vkucera @ktf @alibuild @victor-gonzalez @amatyja @ivorobye @ddobrigk @dsekihat @romainschotter