install tags are wrong

[fmessmer]

I get the following error from our TravisCI job.
It's compiling (rosjava) workspaces via catkin build with "install" option activated (i.e. catkin config --install)

Errors     << rosjava_bootstrap:install /root/catkin_ws/logs/rosjava_bootstrap/build.install.000.log
CMake Error at cmake_install.cmake:133 (file):
  file INSTALL cannot find
  "/root/catkin_ws/devel/.private/rosjava_bootstrap/share/maven/org/ros/rosjava_bootstrap".

the respective install tag is

install(DIRECTORY ${CATKIN_DEVEL_PREFIX}/${CATKIN_GLOBAL_MAVEN_DESTINATION}/org/ros/rosjava_bootstrap/ 
DESTINATION ${CATKIN_GLOBAL_MAVEN_DESTINATION}/org/ros/rosjava_bootstrap)

there seems to be a discrepancy for CATKIN_DEVEL_PREFIX between catkin_make and catkin-tools: https://answers.ros.org/question/248718/catkin_devel_prefix-in-catkin_make-vs-catkin-tools/

also, I can't seem to find the code where CATKIN_GLOBAL_MAVEN_DESTINATION is set.
it seems to be set to share/maven given the error notification above...

anyway:
what would be wrong about setting the install tag to

install(DIRECTORY ${ROS_MAVEN_DEPLOYMENT_REPOSITORY}/org/ros/rosjava_bootstrap/ 
DESTINATION ${CATKIN_GLOBAL_MAVEN_DESTINATION}/org/ros/rosjava_bootstrap)

or even drop the intall tag as "installing" should be done via the gradle wrappers install task, right?

this problem applies for several repos:

• rosjava_bootstrap
• rosjava_messages
• rosjava_core

[fmessmer]

does it actually make sense to install the maven artifacts?
I guess they could also be removed as they will be found via the ROS_MAVEN_* environment variables

[jubeira]

Hi @fmessmer, sorry for the delay; I've been out for some weeks.

I'm not very into the details of these subtle differences between catkin_make and catkin tools.
Just to have a heads up before testing this, will this change affect users using catkin_make?