From 1365790ab66e855833aeb8d68a8210066eedf201 Mon Sep 17 00:00:00 2001 From: jhaddixcodes Date: Fri, 10 Apr 2026 13:22:51 -0700 Subject: [PATCH 1/3] raise error if an unmapped alternate subcategory is passed in --- qbreader/_api_utils.py | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/qbreader/_api_utils.py b/qbreader/_api_utils.py index c138c32..164d642 100644 --- a/qbreader/_api_utils.py +++ b/qbreader/_api_utils.py @@ -149,7 +149,13 @@ def category_correspondence( return (Category.LITERATURE, None) # Accounts for AlternateSubcategory.PRACTICES and AlternateSubcategory.BELIEFS - return (None, None) + if typed_alt_subcat in [ + AlternateSubcategory.PRACTICES, + AlternateSubcategory.BELIEFS + ]: + return (None, None) + + raise ValueError(f"Unmapped alternate subcategory: {typed_alt_subcat}") def normalize_cats( From d0ec08c8c39ee71d6de84b396b06af930f35e1bf Mon Sep 17 00:00:00 2001 From: jhaddixcodes Date: Fri, 10 Apr 2026 13:51:37 -0700 Subject: [PATCH 2/3] remove old comment, add comment to error raising --- qbreader/_api_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qbreader/_api_utils.py b/qbreader/_api_utils.py index 164d642..f7c906b 100644 --- a/qbreader/_api_utils.py +++ b/qbreader/_api_utils.py @@ -148,13 +148,13 @@ def category_correspondence( ]: return (Category.LITERATURE, None) - # Accounts for AlternateSubcategory.PRACTICES and AlternateSubcategory.BELIEFS if typed_alt_subcat in [ AlternateSubcategory.PRACTICES, AlternateSubcategory.BELIEFS ]: return (None, None) + # Alternate subcategory passed in isn't mapped to a category/subcategory raise ValueError(f"Unmapped alternate subcategory: {typed_alt_subcat}") From 344f0737d4b1e9379de629033676064d61230f3c Mon Sep 17 00:00:00 2001 From: jhaddixcodes Date: Sat, 11 Apr 2026 18:01:26 -0700 Subject: [PATCH 3/3] add trailing comma to ensure compliance with linting --- qbreader/_api_utils.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qbreader/_api_utils.py b/qbreader/_api_utils.py index f7c906b..013d033 100644 --- a/qbreader/_api_utils.py +++ b/qbreader/_api_utils.py @@ -150,7 +150,7 @@ def category_correspondence( if typed_alt_subcat in [ AlternateSubcategory.PRACTICES, - AlternateSubcategory.BELIEFS + AlternateSubcategory.BELIEFS, ]: return (None, None)