Netbeans cannot find git commit signing component

[wolfgangreder]

Apache NetBeans version

Apache NetBeans 27

What happened

When i try to commit a change to github with commit signing active netbeans fails to commit with the following stacktrace:

INFO [org.netbeans.modules.git]: org.eclipse.jgit.api.errors.UnsupportedSigningFormatException: No signer for openpgp signatures. Use another signature type for git config gpg.format, or do not sign.
org.eclipse.jgit.api.errors.UnsupportedSigningFormatException: No signer for openpgp signatures. Use another signature type for git config gpg.format, or do not sign.
	at org.eclipse.jgit.api.CommitCommand.sign(CommitCommand.java:327)
	at org.eclipse.jgit.api.CommitCommand.call(CommitCommand.java:281)
	at org.netbeans.libs.git.jgit.commands.CommitCommand.run(CommitCommand.java:138)
Caused: org.netbeans.libs.git.GitException
	at org.netbeans.libs.git.jgit.commands.CommitCommand.run(CommitCommand.java:153)
	at org.netbeans.libs.git.jgit.commands.GitCommand$1.run(GitCommand.java:56)
	at org.netbeans.libs.git.jgit.commands.GitCommand$1.run(GitCommand.java:53)
	at java.base/java.security.AccessController.doPrivileged(AccessController.java:571)
	at org.netbeans.libs.git.jgit.commands.GitCommand.execute(GitCommand.java:53)
	at org.netbeans.libs.git.GitClient.commit(GitClient.java:491)
	at org.netbeans.modules.git.client.GitClient$9.call(GitClient.java:298)
	at org.netbeans.modules.git.client.GitClient$9.call(GitClient.java:294)
	at org.netbeans.modules.git.client.GitClient$CommandInvoker$1$1.call(GitClient.java:945)
	at org.netbeans.modules.git.client.GitClient$CommandInvoker$1.call(GitClient.java:968)
	at org.netbeans.modules.git.FilesystemInterceptor.runWithoutExternalEvents(FilesystemInterceptor.java:477)
	at org.netbeans.modules.git.Git.runWithoutExternalEvents(Git.java:259)
	at org.netbeans.modules.git.client.GitClient$CommandInvoker.runMethodIntern(GitClient.java:978)
	at org.netbeans.modules.git.client.GitClient$CommandInvoker.runMethod(GitClient.java:905)
	at org.netbeans.modules.git.client.GitClient.commit(GitClient.java:294)
	at org.netbeans.modules.git.ui.commit.CommitAction$CommitProgressSupport.commit(CommitAction.java:343)
[catch] at org.netbeans.modules.git.ui.commit.CommitAction$CommitProgressSupport.perform(CommitAction.java:234)
	at org.netbeans.modules.git.client.GitProgressSupport.performIntern(GitProgressSupport.java:92)
	at org.netbeans.modules.git.client.GitProgressSupport.run(GitProgressSupport.java:85)
	at org.openide.util.RequestProcessor$Task.run(RequestProcessor.java:1403)
	at org.netbeans.modules.openide.util.GlobalLookup.execute(GlobalLookup.java:45)
	at org.openide.util.lookup.Lookups.executeWith(Lookups.java:287)

Language / Project Type / NetBeans Component

Java/Gradle

How to reproduce

1. Checkout git repo
2. Change some file
3. try to commit

Did this work correctly in an earlier version?

No / Don't know

Operating System

Linux

JDK

jdk23

Apache NetBeans packaging

Apache NetBeans binary zip

Anything else

No response

Are you willing to submit a pull request?

No

[timothystone]

Been around a while... I usually drop to the Terminal to commit, in NB or externally.

Possibly related to #4439.

See also...
https://issues.apache.org/jira/browse/NETBEANS-3979
https://issues.apache.org/jira/browse/NETBEANS-3972

[plotters]

Commit with gpgsign=true work fine in NetBeans 25 in my case.

In NetBeans 25 I get this:

409:INFO [org.netbeans.core.netigso.Netigso]: bundle org.eclipse.jgit.gpg.bc@7.0.0.202409031743-r resolved

This bundle is no longer resolved in NetBeans 28 and 29. How to verify that it is still loaded? Maybe a regression from #9020 ?

[matthiasblaesing]

I think the problem is the to old bouncy castle version. This is the imported package list (extracted from manifest and split):

org.bouncycastle.asn1;version="[1.79.0,2.0.0)",
org.bouncycastle.asn1.x9;version="[1.79.0,2.0.0)",
org.bouncycastle.bcpg;version="[1.79.0,2.0.0)",
org.bouncycastle.bcpg.sig;version="[1.79.0,2.0.0)",
org.bouncycastle.crypto.ec;version="[1.79.0,2.0.0)",
org.bouncycastle.gpg;version="[1.79.0,2.0.0)",
org.bouncycastle.gpg.keybox;version="[1.79.0,2.0.0)",
org.bouncycastle.gpg.keybox.jcajce;version="[1.79.0,2.0.0)",
org.bouncycastle.jcajce.interfaces;version="[1.79.0,2.0.0)",
org.bouncycastle.jcajce.util;version="[1.79.0,2.0.0)",
org.bouncycastle.math.ec;version="[1.79.0,2.0.0)",
org.bouncycastle.math.field;version="[1.79.0,2.0.0)",
org.bouncycastle.openpgp;version="[1.79.0,2.0.0)",
org.bouncycastle.openpgp.jcajce;version="[1.79.0,2.0.0)",
org.bouncycastle.openpgp.operator;version="[1.79.0,2.0.0)",
org.bouncycastle.openpgp.operator.jcajce;version="[1.79.0,2.0.0)",
org.bouncycastle.util.encoders;version="[1.79.0,2.0.0)",
org.slf4j;version="[1.7.0,3.0.0)"

So we'll need bouncy castle version 1.79.0. We currently carry 1.77.0. Bumping bouncy castle should be trivial, but it fails to load into netbeans as the equinox verifier rejects the Import-Package syntax for the bouncy castle modules:

     [exec] WARNING [org.netbeans.core.netigso.Netigso]: Cannot fake bcpg
     [exec] org.osgi.framework.BundleException: Invalid manifest header Import-Package: "java.io;resolution:="optional"" : Cannot specify java.* packages in Import/Export headers "java.io"
     [exec]     at org.eclipse.osgi.internal.resolver.StateBuilder.checkImportExportSyntax(StateBuilder.java:824)
     [exec]     at org.eclipse.osgi.internal.resolver.StateBuilder.validateHeaders(StateBuilder.java:212)
     [exec]     at org.eclipse.osgi.internal.resolver.StateBuilder.createBundleDescription(StateBuilder.java:63)
     [exec]     at org.eclipse.osgi.internal.resolver.StateObjectFactoryImpl.createBundleDescription(StateObjectFactoryImpl.java:33)
     [exec]     at org.eclipse.osgi.internal.baseadaptor.BaseStorage.updateState(BaseStorage.java:1216)
     [exec]     at org.eclipse.osgi.internal.baseadaptor.BundleInstall.commit(BundleInstall.java:123)
     [exec]     at org.eclipse.osgi.framework.internal.core.Framework.installWorkerPrivileged(Framework.java:978)
     [exec]     at org.eclipse.osgi.framework.internal.core.Framework$1.run(Framework.java:853)
     [exec]     at org.eclipse.osgi.framework.internal.core.Framework$1.run(Framework.java:848)
     [exec]     at java.base/java.security.AccessController.doPrivileged(AccessController.java:571)
     [exec]     at org.eclipse.osgi.framework.internal.core.Framework.installWorker(Framework.java:912)
     [exec]     at org.eclipse.osgi.framework.internal.core.Framework.installBundle(Framework.java:848)
     [exec]     at org.eclipse.osgi.framework.internal.core.BundleContextImpl.installBundle(BundleContextImpl.java:137)
     [exec]     at org.netbeans.modules.netbinox.Netbinox$Context.installBundle(Netbinox.java:143)
     [exec]     at org.netbeans.modules.netbinox.Netbinox$Context.installBundle(Netbinox.java:122)
     [exec]     at org.netbeans.core.netigso.Netigso.fakeOneModule(Netigso.java:504)
     [exec] Caused: java.io.IOException
     [exec]     at org.netbeans.core.netigso.Netigso.fakeOneModule(Netigso.java:530)
     [exec] [catch] at org.netbeans.core.netigso.Netigso.prepare(Netigso.java:156)
     [exec]     at org.netbeans.NetigsoHandle.turnOn(NetigsoHandle.java:115)
     [exec]     at org.netbeans.ModuleManager.doEnable(ModuleManager.java:1488)
     [exec]     at org.netbeans.ModuleManager.enable(ModuleManager.java:1343)
     [exec]     at org.netbeans.ModuleManager.enable(ModuleManager.java:1266)
     [exec]     at org.netbeans.core.startup.ModuleList.installNew(ModuleList.java:313)
     [exec]     at org.netbeans.core.startup.ModuleList.trigger(ModuleList.java:249)
     [exec]     at org.netbeans.core.startup.ModuleSystem.restore(ModuleSystem.java:294)
     [exec]     at org.netbeans.core.startup.Main.getModuleSystem(Main.java:174)
     [exec]     at org.netbeans.core.startup.Main.getModuleSystem(Main.java:143)
     [exec]     at org.netbeans.core.startup.Main.start(Main.java:305)
     [exec]     at org.netbeans.core.startup.TopThreadGroup.run(TopThreadGroup.java:97)
     [exec]     at java.base/java.lang.Thread.run(Thread.java:1583)

[matthiasblaesing]

Please have a look at #9329. That is an experimental PR that bumps bouncy castle version, modifies netbinox/equinox integration to be able to load bouncy castle and was locally tested to be able to sign.

A nightly build to test is available from https://github.com/apache/netbeans/suites/64100077647/artifacts/6370738126